On Monday 31 January 2005 05:11, Lucas Correia Villa Real wrote:

Hi,

This patch just fixes some typos and adds retval documentation for some
functions that were missing it.

I've also a question here: skeletonfb says that  xxxfb_setcolreg() should
return a negative errno on error. However, if the register number being
accessed is out of bounds, 1 is returned. Shouldn't it be better to return
-EINVAL instead?  By looking at fbcmap.c, the retval isn't being checked
against positive/negative values, so it doesn't make sense to return 1.

Thanks,

Please, add a "Signed-off-by:" line next time.

Tony




-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl