Thread (3 messages) 3 messages, 3 authors, 2005-02-04

[PATCH] skeletonfb

flat view
STALE7915d

From: Lucas Correia Villa Real <hidden>
Date: 2005-01-30 21:09:19

Hi,

This patch just fixes some typos and adds retval documentation for some 
functions that were missing it.

I've also a question here: skeletonfb says that  xxxfb_setcolreg() should 
return a negative errno on error. However, if the register number being 
accessed is out of bounds, 1 is returned. Shouldn't it be better to return 
-EINVAL instead?  By looking at fbcmap.c, the retval isn't being checked 
against positive/negative values, so it doesn't make sense to return 1. 

Thanks,

-- 
Lucas
powered by /dev/dsp

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help