Re: [PATCH] fbdev: workaround for broken X servers
flat view
From: Ville Syrjälä <syrjala@sci.fi>
Date: 2004-11-05 15:30:32
On Fri, Nov 05, 2004 at 01:15:35PM +0100, Geert Uytterhoeven wrote:
On Fri, 5 Nov 2004, Benjamin Herrenschmidt wrote:quoted
quoted
But every existing application that uses (shiver) the kernel headers will break after this change...Geert, can you explain the whole story please ?The story about the +1 or the story about the breakage? The Story About The +1 ---------------------- Since the VESA levels do not provide a way to blank (`make it black') the screen, the +1 is introduced. Hence 0 means unblank, 1 means black screen, 2 means lowest power save level, and so on... The Story About The Breakage ---------------------------- Every application that passes VESA_*+1 will break when recompiled, since (most of) the VESA_* values are incremented by 1 by the patch.
My proposed patch doesn't touch the VESA_* values. It just adds new constants which match the VESA_*+1 convention. That way old apps will continue to work and developers don't have to guess what values are actully legal. -- Ville Syrjälä syrjala@sci.fi http://www.sci.fi/~syrjala/ ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_idU88&alloc_id065&op=click