Re: fbdraw 0.1 available

Antonino A. Daplas wrote:

1. First, you need to follow Documentation/CodingStyle.

OK, I've made some strides in that direction.

2. Do not directly access framebuffer memory, use: 
3. Do not use copy_{to|from}_user when the destination/source is the
framebuffer.
4. Do not memset the framebuffer.  You can probably create an equivalent
function using fb_read/write.  (Once, we have fb_memset and fb_memcpy, but
they're gone in 2.6).

Fixed.

Incidentally I am wondering, with cross-platform compatibility
in mind I have been coding assuming that fb_{read|write}[wl] must be
short/long aligned. Is that assumption correct?

I've also added my copyarea routine. At first I tried to make use
of cfb_copyarea but it proved very buggy in 24bpp.

New code is at http://home.comcast.net/~plinius.
Cheers,
Zack


-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM. 
Deadline: Sept. 13. Go here: http://sf.net/ppc_contest.php