Re: Fw: Rivafb I2C problem, new patch
From: Antonino A. Daplas <hidden>
Date: 2004-07-13 01:58:30
On Tuesday 13 July 2004 07:39, Andrew Morton wrote:
Maybe Greg, or the linux-fbdev-devel denizens can comment upon this? Begin forwarded message: Date: Tue, 13 Jul 2004 01:24:02 +0200 From: Nicolas Boichat <redacted> To: akpm@digeo.com Subject: Rivafb I2C problem, new patch Hello, I'm currently writing a DDC/CI tool for Linux (DDC/CI is the protocol which permits to modify monitor parameters without using the OSD), see http://www.boichat.ch/nicolas/ddcci . I use the new rivafb I2C support, but a problem appeared: the I2C bus is immediately deleted after the DDC2 EDID is read, but I need to access it from my application! I attached a patch which fixes this problem: the bus is deleted only when the driver is unloaded (please note that the atyfb behave like my patched version). Could you add it to the next -mm kernel release ? I also contacted the driver maintainer but he seems not to answer (I sent an e-mail to him about a week ago).
I'm not the maintainer of rivafb but I added the DDC2 support for it. The bus was destroyed because there was no use for it after reading the EDID block, and fbdev has no interface (yet) to re-read it again. It doesn't matter to me whether the bus is immediately deleted or not, so the patch is fine by me. Tony ------------------------------------------------------- This SF.Net email sponsored by Black Hat Briefings & Training. Attend Black Hat Briefings & Training, Las Vegas July 24-29 - digital self defense, top technical experts, no vendor pitches, unmatched networking opportunities. Visit www.blackhat.com