Fw: Rivafb I2C problem, new patch

Maybe Greg, or the linux-fbdev-devel denizens can comment upon
this?


Begin forwarded message:

Date: Tue, 13 Jul 2004 01:24:02 +0200
From: Nicolas Boichat <redacted>
To: akpm@digeo.com
Subject: Rivafb I2C problem, new patch


Hello,

I'm currently writing a DDC/CI tool for Linux (DDC/CI is the protocol which permits to modify monitor parameters without using the OSD), see http://www.boichat.ch/nicolas/ddcci .

I use the new rivafb I2C support, but a problem appeared: the I2C bus is immediately deleted after the DDC2 EDID is read, but I need to access it from my application!

I attached a patch which fixes this problem: the bus is deleted only when the driver is unloaded (please note that the atyfb behave like my patched version). Could you add it to the next -mm kernel release ?

I also contacted the driver maintainer but he seems not to answer (I sent an e-mail to him about a week ago).

Best regards,

Nicolas Boichat

On Mon, Jul 12, 2004 at 04:39:42PM -0700, Andrew Morton wrote:

Maybe Greg, or the linux-fbdev-devel denizens can comment upon
this?


Begin forwarded message:

Date: Tue, 13 Jul 2004 01:24:02 +0200
From: Nicolas Boichat <redacted>
To: akpm@digeo.com
Subject: Rivafb I2C problem, new patch


Hello,

I'm currently writing a DDC/CI tool for Linux (DDC/CI is the protocol
which permits to modify monitor parameters without using the OSD), see
http://www.boichat.ch/nicolas/ddcci .

I use the new rivafb I2C support, but a problem appeared: the I2C bus
is immediately deleted after the DDC2 EDID is read, but I need to
access it from my application!

I attached a patch which fixes this problem: the bus is deleted only
when the driver is unloaded (please note that the atyfb behave like my
patched version). Could you add it to the next -mm kernel release ?

Well, you shouldn't comment out those calls, just delete them.

Other than that, from an i2c standpoint, the patch looks sane, but I
would check with the maintainer, as there might be some reason they
delete the bus right after using it.

thanks,

greg k-h


-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com

On Tuesday 13 July 2004 07:39, Andrew Morton wrote:

Maybe Greg, or the linux-fbdev-devel denizens can comment upon
this?


Begin forwarded message:

Date: Tue, 13 Jul 2004 01:24:02 +0200
From: Nicolas Boichat <redacted>
To: akpm@digeo.com
Subject: Rivafb I2C problem, new patch


Hello,

I'm currently writing a DDC/CI tool for Linux (DDC/CI is the protocol which
permits to modify monitor parameters without using the OSD), see
http://www.boichat.ch/nicolas/ddcci .

I use the new rivafb I2C support, but a problem appeared: the I2C bus is
immediately deleted after the DDC2 EDID is read, but I need to access it
from my application!

I attached a patch which fixes this problem: the bus is deleted only when
the driver is unloaded (please note that the atyfb behave like my patched
version). Could you add it to the next -mm kernel release ?

I also contacted the driver maintainer but he seems not to answer (I sent
an e-mail to him about a week ago).

I'm not the maintainer of rivafb but I added the DDC2 support for it. The bus
was destroyed because there was no use for it after reading the EDID block,
and fbdev has no interface (yet) to re-read it again.

It doesn't matter to me whether the bus is immediately deleted or not, so the
patch is fine by me.

Tony 




-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com

Hello,

Thanks for your answers.

I attached a new patch: I deleted the lines that were commented out.

Best regards,

Nicolas

On Tue, 2004-07-13 at 03:58, Antonino A. Daplas wrote:

I'm not the maintainer of rivafb but I added the DDC2 support for it. The bus
was destroyed because there was no use for it after reading the EDID block,
and fbdev has no interface (yet) to re-read it again.

It doesn't matter to me whether the bus is immediately deleted or not, so the
patch is fine by me.

Tony 

On Tue, 2004-07-13 at 01:43, Greg KH wrote: 

Well, you shouldn't comment out those calls, just delete them.

Other than that, from an i2c standpoint, the patch looks sane, but I
would check with the maintainer, as there might be some reason they
delete the bus right after using it.

thanks,

greg k-h

On Tuesday 13 July 2004 17:53, Nicolas Boichat wrote:

Hello,

Thanks for your answers.

I attached a new patch: I deleted the lines that were commented out.

One thing I forgot, make sure it compiles when CONFIG_FB_RIVA_I2C is
set or not.

Tony




-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com

Hello,

Good idea... it didn't compile. Fixed patch attached.

Best regards,

Nicolas

On Tue, 2004-07-13 at 22:52, Antonino A. Daplas wrote:

On Tuesday 13 July 2004 17:53, Nicolas Boichat wrote:

quoted

Hello,

Thanks for your answers.

I attached a new patch: I deleted the lines that were commented out.

One thing I forgot, make sure it compiles when CONFIG_FB_RIVA_I2C is
set or not.

Tony

Nicolas Boichat [off-list ref] wrote:

Good idea... it didn't compile. Fixed patch attached.

Please send a complete new patch, with a changelog.

Thanks.


-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com

Hello,

This should be the last patch, the changelog is at the beginning of the
file.

Best regards,

Nicolas

On Wed, 2004-07-14 at 00:02, Andrew Morton wrote:

Nicolas Boichat [off-list ref] wrote:

quoted

Good idea... it didn't compile. Fixed patch attached.

Please send a complete new patch, with a changelog.

Thanks.