Re: [PATCH] atyfb (2.6): Add RGB565 support

Geert Uytterhoeven wrote:

Hi Ville,

On Wed, 12 May 2004, Ville [iso-8859-1] Syrjälä wrote:
 

quoted

On Wed, May 12, 2004 at 11:11:21AM +0200, Geert Uytterhoeven wrote:
   

quoted

On Wed, 12 May 2004, Ville [iso-8859-1] Syrjälä wrote:
     

quoted

This patch adds RGB565 support to atyfb.
       

Nice! Have you tried fbtest on it?

I once tried to implement it myself, but it didn't work reliably.
     

I just tried fbtest and most tests look ok. The penguin images are wrong
(green instead of white stuff aroung the penguin) and the test009 looks
wrong too. Are you sure fbtest is doing the right thing with rgb565
directcolor visuals? DirectFB or mplayer don't have any problems.
   

It's always possible there's a bug in fbtest w.r.t. 565 handling, but I didn't
see it.
 

It's a bug in fbtest's directcolor routines.   Directcolor sets the clut using using the min of the RGB sizes so 565 becomes 555.  The problem is that tests 4, 8 and 9 use the buffer as 565 (VISUAL_GENERIC & VISUAL_TRUECOLOR) and the directcolor routines don't reset the clut to it's full range.  Fix attached.

John