[PATCH] atyfb (2.6): Add RGB565 support
From: Ville Syrjälä <syrjala@sci.fi>
Date: 2004-05-11 21:36:11
This patch adds RGB565 support to atyfb. -- Ville Syrjälä syrjala@sci.fi http://www.sci.fi/~syrjala/
[PATCH] atyfb (2.6): Add RGB565 support
STALE8122d
7 messages, 3 authors, 2004-05-14 · open the first message on its own page
Re: [PATCH] atyfb (2.6): Add RGB565 support
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2004-05-12 09:11:26
On Wed, 12 May 2004, Ville [iso-8859-1] Syrjälä wrote:
This patch adds RGB565 support to atyfb.
Nice! Have you tried fbtest on it?
I once tried to implement it myself, but it didn't work reliably.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-------------------------------------------------------
This SF.Net email is sponsored by Sleepycat Software
Learn developer strategies Cisco, Motorola, Ericsson & Lucent use to
deliver higher performing products faster, at low TCO.
http://www.sleepycat.com/telcomwpreg.php?From=osdnemail3
Re: [PATCH] atyfb (2.6): Add RGB565 support
From: Ville Syrjälä <syrjala@sci.fi>
Date: 2004-05-12 18:57:28
On Wed, May 12, 2004 at 11:11:21AM +0200, Geert Uytterhoeven wrote:
On Wed, 12 May 2004, Ville [iso-8859-1] Syrjälä wrote:quoted
This patch adds RGB565 support to atyfb.Nice! Have you tried fbtest on it? I once tried to implement it myself, but it didn't work reliably.
I just tried fbtest and most tests look ok. The penguin images are wrong (green instead of white stuff aroung the penguin) and the test009 looks wrong too. Are you sure fbtest is doing the right thing with rgb565 directcolor visuals? DirectFB or mplayer don't have any problems. -- Ville Syrjälä syrjala@sci.fi http://www.sci.fi/~syrjala/ ------------------------------------------------------- This SF.Net email is sponsored by Sleepycat Software Learn developer strategies Cisco, Motorola, Ericsson & Lucent use to deliver higher performing products faster, at low TCO. http://www.sleepycat.com/telcomwpreg.php?From=osdnemail3
Re: [PATCH] atyfb (2.6): Add RGB565 support
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2004-05-13 09:22:07
Hi Ville, On Wed, 12 May 2004, Ville [iso-8859-1] Syrjälä wrote:
On Wed, May 12, 2004 at 11:11:21AM +0200, Geert Uytterhoeven wrote:quoted
On Wed, 12 May 2004, Ville [iso-8859-1] Syrjälä wrote:quoted
This patch adds RGB565 support to atyfb.Nice! Have you tried fbtest on it? I once tried to implement it myself, but it didn't work reliably.I just tried fbtest and most tests look ok. The penguin images are wrong (green instead of white stuff aroung the penguin) and the test009 looks wrong too. Are you sure fbtest is doing the right thing with rgb565 directcolor visuals? DirectFB or mplayer don't have any problems.
It's always possible there's a bug in fbtest w.r.t. 565 handling, but I didn't
see it.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id%62&alloc_ida84&op=click
Re: [PATCH] atyfb (2.6): Add RGB565 support
From: Ville Syrjälä <syrjala@sci.fi>
Date: 2004-05-13 19:19:52
On Thu, May 13, 2004 at 11:22:01AM +0200, Geert Uytterhoeven wrote:
Hi Ville, On Wed, 12 May 2004, Ville [iso-8859-1] Syrjälä wrote:quoted
On Wed, May 12, 2004 at 11:11:21AM +0200, Geert Uytterhoeven wrote:quoted
On Wed, 12 May 2004, Ville [iso-8859-1] Syrjälä wrote:quoted
This patch adds RGB565 support to atyfb.Nice! Have you tried fbtest on it? I once tried to implement it myself, but it didn't work reliably.I just tried fbtest and most tests look ok. The penguin images are wrong (green instead of white stuff aroung the penguin) and the test009 looks wrong too. Are you sure fbtest is doing the right thing with rgb565 directcolor visuals? DirectFB or mplayer don't have any problems.It's always possible there's a bug in fbtest w.r.t. 565 handling, but I didn't see it.
It has the same problems on aty128fb so either that driver is broken too or the fault lies with fbtest. On matroxfb RGB565 is fine but matroxfb uses a truecolor visual. -- Ville Syrjälä syrjala@sci.fi http://www.sci.fi/~syrjala/ ------------------------------------------------------- This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id%62&alloc_ida84&op=click
Re: [PATCH] atyfb (2.6): Add RGB565 support
From: John Zielinski <hidden>
Date: 2004-05-14 01:11:57
Geert Uytterhoeven wrote:
Hi Ville, On Wed, 12 May 2004, Ville [iso-8859-1] Syrjälä wrote:quoted
On Wed, May 12, 2004 at 11:11:21AM +0200, Geert Uytterhoeven wrote:quoted
On Wed, 12 May 2004, Ville [iso-8859-1] Syrjälä wrote:quoted
This patch adds RGB565 support to atyfb.Nice! Have you tried fbtest on it? I once tried to implement it myself, but it didn't work reliably.I just tried fbtest and most tests look ok. The penguin images are wrong (green instead of white stuff aroung the penguin) and the test009 looks wrong too. Are you sure fbtest is doing the right thing with rgb565 directcolor visuals? DirectFB or mplayer don't have any problems.It's always possible there's a bug in fbtest w.r.t. 565 handling, but I didn't see it.
It's a bug in fbtest's directcolor routines. Directcolor sets the clut using using the min of the RGB sizes so 565 becomes 555. The problem is that tests 4, 8 and 9 use the buffer as 565 (VISUAL_GENERIC & VISUAL_TRUECOLOR) and the directcolor routines don't reset the clut to it's full range. Fix attached. John
Re: [PATCH] atyfb (2.6): Add RGB565 support
From: Ville Syrjälä <syrjala@sci.fi>
Date: 2004-05-14 04:53:41
On Thu, May 13, 2004 at 09:11:47PM -0400, John Zielinski wrote:
Geert Uytterhoeven wrote:quoted
It's always possible there's a bug in fbtest w.r.t. 565 handling, but I didn't see it.It's a bug in fbtest's directcolor routines. Directcolor sets the clut using using the min of the RGB sizes so 565 becomes 555. The problem is that tests 4, 8 and 9 use the buffer as 565 (VISUAL_GENERIC & VISUAL_TRUECOLOR) and the directcolor routines don't reset the clut to it's full range. Fix attached.
Looks perfect with this patch. However I just realized that the atyfb patch will not work correctly with partial color map updates. Revised patch coming up... -- Ville Syrjälä syrjala@sci.fi http://www.sci.fi/~syrjala/ ------------------------------------------------------- This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id%62&alloc_ida84&op=click