On Sat, 1 May 2004, Andrew Morton wrote:

Geert Uytterhoeven [off-list ref] wrote:

quoted

 > You've taken a bunch of previously-working 3d acceleration functions and
 > made them configurable, dependent upon CONFIG_EXPERIMENTAL.
 >
 > What on earth for?  Will this not gratuitously break people's
 > previously-working 3d setups?

 No, tdfxfb_cursor() was not used before, causing a compiler warning.
 tdfxfb_cursor() may work, but we don't know, so we didn't dare to enable it by
 default. Now the user (he who has the hardware) can enable it, and tell us
 whether it works or not.

OK, thanks.  As you can see, it really helps if people explain this sort of
thing in their initial patch (sigh).

Does the same argument apply to this patch?

Yes. All these patches should enable the currently unused acceleration routines
if the corresponding config option is set, and kill the compiler warnings if
its not set.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE. 
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click