On Fri, 30 Apr 2004, Andrew Morton wrote:

"Luiz Fernando N. Capitulino" [off-list ref] wrote:

quoted

 This patch fixes this warning:

  drivers/video/tdfxfb.c:1005: warning: `tdfxfb_cursor' defined but not
  used

  and make the acceleration function selectable (like hgafb
 and tridentfb):

You've taken a bunch of previously-working 3d acceleration functions and
made them configurable, dependent upon CONFIG_EXPERIMENTAL.

What on earth for?  Will this not gratuitously break people's
previously-working 3d setups?

No, tdfxfb_cursor() was not used before, causing a compiler warning.
tdfxfb_cursor() may work, but we don't know, so we didn't dare to enable it by
default. Now the user (he who has the hardware) can enable it, and tell us
whether it works or not.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE. 
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click