Re: [PATCH] neofb patches
From: James Simmons <hidden>
Date: 2004-04-25 00:55:24
Also in:
lkml
Umm, I would really appreciate it if you didn't silently leave out bits of my patches and then just say "I merged your patches". It took me a little bit to figure out that the reason panning now isn't used for fbconsole scrolls is because you just didn't bother to put that part of my patch in. Is there some reason you left out the following piece of my modedb patch? + /* Turn on panning for console scroll by default */ + info->var.yres_virtual = 30000; + info->var.accel_flags |= FB_ACCELF_TEXT; + if (neofb_check_var(&info->var, info)) + goto err_map_video;
The reason is because fb_find_mode calls check_var for us. No reason to call it twice. The large yres_virtual being 30000 that is not needed any longer. The accel flag is set in neofb_check_var. The current test is if (var->bits_per_pixel >= 24 || !par->neo2200) var->accel_flags &= ~FB_ACCEL_TEXT; Should we drop the bpp >= 24 test? Do you observe this problem at all depths. ------------------------------------------------------- This SF.net email is sponsored by: The Robotic Monkeys at ThinkGeek For a limited time only, get FREE Ground shipping on all orders of $35 or more. Hurry up and shop folks, this offer expires April 30th! http://www.thinkgeek.com/freeshipping/?cpg=12297