Thread (67 messages) 67 messages, 8 authors, 2004-04-30

Re: [PATCH] radeonfb(): memmove() fix -- this one works ;-)

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2004-04-27 23:31:01

Possibly related (same subject, not in this thread)

On Wed, 2004-04-28 at 09:18, James Simmons wrote:
quoted
a regression from 2.4 and I don't think his patch will be more invasive
than the rest of the changes you have been doing lately ;)

Face it, the current fbcon resize mecanism is just broken. It cannot
work properly without full mode management in all drivers. A per-VT var
along with fbcon properly adapting it's size to the VT's var would bring
us back to 2.4 level of functionality at least, which is a good thing.
I refuse to have hacks to deal with a cripple VT system. What is 
acceptable is that we add what we need to struct vc_data. You do that and 
I have no problem then. From what I can see we need the following.

1) Color depth.
2) Frequency.
3) Over scan color.
No, no, no ... We don't need those, we need a var structure, that's all.
Anything else? 

Personally I rather add these to struct vc_data. Consider if we ever had 
hardware that supported different hardware text modes. Say some at 
different color depths. I rather do this!!




-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE. 
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help