Maciej W. Rozycki wrote:

On Thu, 14 Aug 2003, Thiemo Seufer wrote:

quoted

quoted

 I've looked at the patch and have changed the barriers as I deem
appropriate.  But while doing this, I've noticed the code is insonsistent
in a few places -- has it been successfully verified on real hardware?

There are some mb() calls in your patch, I believe a rmb()/wmb() is
enough in those cases.

quoted

It works on my /260. Which parts look weird to you?

1. bt431_write_reg_inc() uses u16 for value, even though it only uses 8
bits (which of course makes all the calls in bt431_init_cursor() dubious). 

2. bt431_load_cursor_sprite() loads control registers instead of the
cursor map. 

The hardware cursor is still unused. The code there is very experimental,
and your version is surely an imporvement. :-)


Thiemo


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf