Thread (20 messages) 20 messages, 5 authors, 2003-09-01

Re: Re: [macro@ds2.pg.gda.pl: Re: PMAG-A support?]

From: Maciej W. Rozycki <hidden>
Date: 2003-08-14 12:20:02

On Thu, 14 Aug 2003, Thiemo Seufer wrote:
quoted
 I've looked at the patch and have changed the barriers as I deem
appropriate.  But while doing this, I've noticed the code is insonsistent
in a few places -- has it been successfully verified on real hardware?
It works on my /260. Which parts look weird to you?
1. bt431_write_reg_inc() uses u16 for value, even though it only uses 8
bits (which of course makes all the calls in bt431_init_cursor() dubious). 

2. bt431_load_cursor_sprite() loads control registers instead of the
cursor map. 

 See the patch for details.  You may use `diff -b' to get rid of spacing
clean-ups -- this makes my updates quite clear. 

  Maciej

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +



-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help