Re: [PATCH] imsttfb 2.5.x
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2003-04-16 08:26:36
On Wed, 2003-04-16 at 00:43, Boris Bezlaj wrote:
On Tue, Apr 15, 2003 at 10:05:29PM +0200, Benjamin Herrenschmidt wrote:quoted
quoted
Does readl handle byte swapping on the PPC. The registers expect the data feed to them to be little endian. Actually this driver will only work on the PPC and ix86 platform. Other big endian platforms are out of luck.It works on ix86? I thought there were problems with ramdac init..must try that someday 8)
Possibly, I never tested
Or would it be better to scrap the read/write_reg_le32 alltogether?
Go on ;) Ben.
quoted hunk ↗ jump to hunk
P.S. Please check http://knjiznica-jesenice.org/~boris/boot/101_0145.JPG What would i need to initialize in ramdac to get rid of "checkerboard" effect? Any ideas?--- linux-2.5.50/drivers/video/ORIG_imsttfb.c 2003-04-15 23:06:29.000000000 +0200 +++ linux-2.5.50/drivers/video/imsttfb.c 2003-04-15 23:07:41.000000000 +0200@@ -408,20 +408,12 @@ */ static inline u32 read_reg_le32(volatile u32 *base, int regindex) { -#ifdef __powerpc__ - return in_le32((volatile u32 *) (base + regindex)); -#else return readl(base + regindex); -#endif } static inline void write_reg_le32(volatile u32 *base, int regindex, u32 val) { -#ifdef __powerpc__ - out_le32((volatile u32 *) (base + regindex), val); -#else writel(val, base + regindex); -#endif } static __u32
-- Benjamin Herrenschmidt [off-list ref] ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf