Re: [PATCH] imsttfb 2.5.x
From: James Simmons <hidden>
Date: 2003-04-15 19:34:12
On Sat, 2003-04-12 at 13:19, Boris Bezlaj wrote:quoted
In 2.5.67 imsttfb locks the system when it's time to scrool the text. Patch below fixes that. Otherwise everything seems to work as in 2.4--- linux/drivers/video/ORIG_imsttfb.c 2003-04-09 15:11:46.000000000 +0200 +++ linux/drivers/video/imsttfb.c 2003-04-11 16:44:07.000000000 +0200@@ -409,7 +409,7 @@ static inline u32 read_reg_le32(volatile u32 *base, int regindex) { #ifdef __powerpc__ - in_le32((volatile u32 *) (base + regindex)); + return in_le32((volatile u32 *) (base + regindex)); #else return readl(base + regindex); #endifThere is actually no reason not to use readl() on ppc as well
Does readl handle byte swapping on the PPC. The registers expect the data feed to them to be little endian. Actually this driver will only work on the PPC and ix86 platform. Other big endian platforms are out of luck. P.S This whole issue really sucks. I really wish there was a clean standard api to this. ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf