Re: Re: [PATCH]: image.depth fix to accomodate monochrome cards

On 13 Feb 2003, Antonino Daplas wrote:

On Thu, 2003-02-13 at 04:50, James Simmons wrote:

quoted

quoted

quoted

1.  Changed meaning of image.depth.  If image.depth == 0, it flags for
color expansion, otherwise, it flags for image drawing (without color
expansion).  This change is to accomodate monochrome cards so they can
differentiate character drawing from logo drawing.

What's the status of this issue? Monochrome is still broken due to this.

How about assigning fb_image.{bg_color,fg_color} to -1 if not color
expanding?  Since the pseudo_palette will not exceed 255, this should be
safe.

Unless we ever want to support colors > 256 (or real pixel values)?

Alternatively, we can split imageblit in two routines, one for image drawing,
and one for color expansion.

So we now have 3 options:
  1. image.depth = 0 means color expansion,
  2. fb_image.{bg_color,fg_color} = -1 means color expansion,
  3. separate functions for image drawing and color expansion.

I still favor solution 1, since image.depth = 0 is not possible for images,
while fb_image.{bg_color,fg_color} = -1 (= 0xffffffff) may become valid in the
future, and the last one is more work to adapt the current drivers.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf