Re: gen_set_var() fix?
From: James Simmons <hidden>
Date: 2002-08-28 18:20:06
James Should't gen_set_var set the var in info here as well? (when no check_var present)
No. The first test is to see if the passed in var is equal to the current var in info. Note info->var is always set before we call gen_set_var. The next set is check if xxfb_check_var is there. If this function is lacking then we know the hardware supports a static mode. Then it just returns the defualt var which is set before we call gen_set_var.
BTW is gen_set_var going to stay in the new API or go away ?
It is to stay. It will be intergrated into fbmem.c once we are done.
quoted hunk ↗ jump to hunk
--- fbgen.c.orig Wed Aug 28 09:49:45 2002 +++ fbgen.c Wed Aug 28 09:57:32 2002@@ -36,7 +36,7 @@ if (con < 0 || (memcmp(&info->var, var, sizeof(struct fb_var_screeninfo)))) { if (!info->fbops->fb_check_var) { - *var = info->var; + info->var = *var; return 0; }
MS: (n) 1. A debilitating and surprisingly widespread affliction that renders the sufferer barely able to perform the simplest task. 2. A disease. James Simmons [jsimmons@users.sf.net] ____/| fbdev/console/gfx developer \ o.O| http://www.linux-fbdev.org =(_)= http://linuxgfx.sourceforge.net U http://linuxconsole.sourceforge.net ------------------------------------------------------- This sf.net email is sponsored by: Jabber - The world's fastest growing real-time communications platform! Don't just IM. Build it in! http://www.jabber.com/osdn/xim