gen_set_var() fix?

James
Should't gen_set_var set the var in info here as well? (when no check_var present)
BTW is gen_set_var going to stay in the new API or go away ?

--- fbgen.c.orig       Wed Aug 28 09:49:45 2002
+++ fbgen.c     Wed Aug 28 09:57:32 2002

@@ -36,7 +36,7 @@

        if (con < 0 || (memcmp(&info->var, var, sizeof(struct fb_var_screeninfo)))) {
                if (!info->fbops->fb_check_var) {
-                       *var = info->var;
+                       info->var = *var;
                        return 0;
                }


-------------------------------------------------------

This sf.net email is sponsored by: Jabber - The world's fastest growing 
real-time communications platform! Don't just IM. Build it in! 
http://www.jabber.com/osdn/xim

On Wed, 2002-08-28 at 18:00, Jani Monoses wrote:

The original code is correct.  It means the driver supports only 1 video
mode, which is the current one in info->var.  

Tony




-------------------------------------------------------
This sf.net email is sponsored by: Jabber - The world's fastest growing 
real-time communications platform! Don't just IM. Build it in! 
http://www.jabber.com/osdn/xim

Thanks
so not having check_var implies we only support one video mode?

quoted

The original code is correct.  It means the driver supports only 1 video
mode, which is the current one in info->var.  

Tony




-------------------------------------------------------
This sf.net email is sponsored by: Jabber - The world's fastest growing 
real-time communications platform! Don't just IM. Build it in! 
http://www.jabber.com/osdn/xim
_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel

-------------------------------------------------------
This sf.net email is sponsored by: Jabber - The world's fastest growing 
real-time communications platform! Don't just IM. Build it in! 
http://www.jabber.com/osdn/xim

On Wed, 28 Aug 2002, Jani Monoses wrote:

so not having check_var implies we only support one video mode?

Yes. This is useful for e.g. handheld devices with LCDs, and for offb.

quoted

The original code is correct.  It means the driver supports only 1 video
mode, which is the current one in info->var.  

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds



-------------------------------------------------------
This sf.net email is sponsored by: Jabber - The world's fastest growing 
real-time communications platform! Don't just IM. Build it in! 
http://www.jabber.com/osdn/xim

James
Should't gen_set_var set the var in info here as well? (when no check_var present)

No. The first test is to see if the passed in var is equal to the current
var in info. Note info->var is always set before we call gen_set_var. The
next set is check if xxfb_check_var is there. If this function is lacking
then we know the hardware supports a static mode. Then it just returns the
defualt var which is set before we call gen_set_var.

BTW is gen_set_var going to stay in the new API or go away ?

It is to stay. It will be intergrated into fbmem.c once we are done.

MS: (n) 1. A debilitating and surprisingly widespread affliction that
renders the sufferer barely able to perform the simplest task. 2. A disease.

James Simmons  [jsimmons@users.sf.net] 	                ____/|
fbdev/console/gfx developer                             \ o.O|
http://www.linux-fbdev.org                               =(_)=
http://linuxgfx.sourceforge.net                            U
http://linuxconsole.sourceforge.net



-------------------------------------------------------
This sf.net email is sponsored by: Jabber - The world's fastest growing 
real-time communications platform! Don't just IM. Build it in! 
http://www.jabber.com/osdn/xim