[PATCH v2 46/54] ext4: remove reference to I_FREEING in orphan.c
From: Josef Bacik <josef@toxicpanda.com>
Date: 2025-08-26 15:41:57
Also in:
linux-btrfs, linux-fsdevel, linux-xfs
Subsystem:
ext4 file system, filesystems (vfs and infrastructure), the rest · Maintainers:
"Theodore Ts'o", Alexander Viro, Christian Brauner, Linus Torvalds
We can use the i_count refcount to see if this inode is being freed. Signed-off-by: Josef Bacik <josef@toxicpanda.com> --- fs/ext4/orphan.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/orphan.c b/fs/ext4/orphan.c
index 524d4658fa40..9ef693b9ad06 100644
--- a/fs/ext4/orphan.c
+++ b/fs/ext4/orphan.c@@ -107,7 +107,8 @@ int ext4_orphan_add(handle_t *handle, struct inode *inode) if (!sbi->s_journal || is_bad_inode(inode)) return 0; - WARN_ON_ONCE(!(inode->i_state & (I_NEW | I_FREEING)) && + WARN_ON_ONCE(!(inode->i_state & I_NEW) && + icount_read(inode) > 0 && !inode_is_locked(inode)); /* * Inode orphaned in orphan file or in orphan list?
@@ -236,7 +237,8 @@ int ext4_orphan_del(handle_t *handle, struct inode *inode) if (!sbi->s_journal && !(sbi->s_mount_state & EXT4_ORPHAN_FS)) return 0; - WARN_ON_ONCE(!(inode->i_state & (I_NEW | I_FREEING)) && + WARN_ON_ONCE(!(inode->i_state & I_NEW) && + icount_read(inode) > 0 && !inode_is_locked(inode)); if (ext4_test_inode_state(inode, EXT4_STATE_ORPHAN_FILE)) return ext4_orphan_file_del(handle, inode);
--
2.49.0