[PATCH v2 09/54] fs: hold an i_obj_count reference while on the hashtable
From: Josef Bacik <josef@toxicpanda.com>
Date: 2025-08-26 15:41:03
Also in:
linux-btrfs, linux-fsdevel, linux-xfs
Subsystem:
filesystems (vfs and infrastructure), the rest · Maintainers:
Alexander Viro, Christian Brauner, Linus Torvalds
While the inode is on the hashtable we need to hold a reference to the object itself. Signed-off-by: Josef Bacik <josef@toxicpanda.com> --- fs/inode.c | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/fs/inode.c b/fs/inode.c
index d426f54c05d9..0c063227d355 100644
--- a/fs/inode.c
+++ b/fs/inode.c@@ -667,6 +667,7 @@ void __insert_inode_hash(struct inode *inode, unsigned long hashval) spin_lock(&inode_hash_lock); spin_lock(&inode->i_lock); + iobj_get(inode); hlist_add_head_rcu(&inode->i_hash, b); spin_unlock(&inode->i_lock); spin_unlock(&inode_hash_lock);
@@ -681,11 +682,16 @@ EXPORT_SYMBOL(__insert_inode_hash); */ void __remove_inode_hash(struct inode *inode) { + bool putref; + spin_lock(&inode_hash_lock); spin_lock(&inode->i_lock); + putref = !hlist_unhashed(&inode->i_hash) && !hlist_fake(&inode->i_hash); hlist_del_init_rcu(&inode->i_hash); spin_unlock(&inode->i_lock); spin_unlock(&inode_hash_lock); + if (putref) + iobj_put(inode); } EXPORT_SYMBOL(__remove_inode_hash);
@@ -1314,6 +1320,7 @@ struct inode *inode_insert5(struct inode *inode, unsigned long hashval, * caller is responsible for filling in the contents */ spin_lock(&inode->i_lock); + iobj_get(inode); inode->i_state |= I_NEW; hlist_add_head_rcu(&inode->i_hash, head); spin_unlock(&inode->i_lock);
@@ -1451,6 +1458,7 @@ struct inode *iget_locked(struct super_block *sb, unsigned long ino) if (!old) { inode->i_ino = ino; spin_lock(&inode->i_lock); + iobj_get(inode); inode->i_state = I_NEW; hlist_add_head_rcu(&inode->i_hash, head); spin_unlock(&inode->i_lock);
@@ -1803,6 +1811,7 @@ int insert_inode_locked(struct inode *inode) } if (likely(!old)) { spin_lock(&inode->i_lock); + iobj_get(inode); inode->i_state |= I_NEW | I_CREATING; hlist_add_head_rcu(&inode->i_hash, head); spin_unlock(&inode->i_lock);
--
2.49.0