Re: [PATCH 06/10] fs/xfs: transition from deprecated .mmap hook to .mmap_prepare

[PATCH 00/10] convert the majority of file systems to mmap_prepare · Lorenzo Stoakes <hidden> · 2025-06-16
[PATCH 05/10] fs/ext4: transition from deprecated .mmap hook to .mmap_prepare · Lorenzo Stoakes <hidden> · 2025-06-16
Re: [PATCH 05/10] fs/ext4: transition from deprecated .mmap hook to .mmap_prepare · Jan Kara <jack@suse.cz> · 2025-06-17
[PATCH 04/10] fs/dax: make it possible to check dev dax support without a VMA · Lorenzo Stoakes <hidden> · 2025-06-16
Re: [PATCH 04/10] fs/dax: make it possible to check dev dax support without a VMA · Matthew Wilcox <willy@infradead.org> · 2025-06-16
Re: [PATCH 04/10] fs/dax: make it possible to check dev dax support without a VMA · Christian Brauner <brauner@kernel.org> · 2025-06-17
[PATCH 02/10] mm/nommu: use file_has_valid_mmap_hooks() helper · Lorenzo Stoakes <hidden> · 2025-06-16
Re: [PATCH 02/10] mm/nommu: use file_has_valid_mmap_hooks() helper · Jan Kara <jack@suse.cz> · 2025-06-17
Re: [PATCH 02/10] mm/nommu: use file_has_valid_mmap_hooks() helper · Vlastimil Babka <hidden> · 2025-06-17
[PATCH 03/10] fs: consistently use file_has_valid_mmap_hooks() helper · Lorenzo Stoakes <hidden> · 2025-06-16
Re: [PATCH 03/10] fs: consistently use file_has_valid_mmap_hooks() helper · Kees Cook <kees@kernel.org> · 2025-06-16
Re: [PATCH 03/10] fs: consistently use file_has_valid_mmap_hooks() helper · Christoph Hellwig <hch@infradead.org> · 2025-06-17
Re: [PATCH 03/10] fs: consistently use file_has_valid_mmap_hooks() helper · Lorenzo Stoakes <hidden> · 2025-06-17
Re: [PATCH 03/10] fs: consistently use file_has_valid_mmap_hooks() helper · Christoph Hellwig <hch@infradead.org> · 2025-06-17
Re: [PATCH 03/10] fs: consistently use file_has_valid_mmap_hooks() helper · Jan Kara <jack@suse.cz> · 2025-06-17
Re: [PATCH 03/10] fs: consistently use file_has_valid_mmap_hooks() helper · Christian Brauner <brauner@kernel.org> · 2025-06-17
[PATCH 06/10] fs/xfs: transition from deprecated .mmap hook to .mmap_prepare · Lorenzo Stoakes <hidden> · 2025-06-16
Re: [PATCH 06/10] fs/xfs: transition from deprecated .mmap hook to .mmap_prepare · Christoph Hellwig <hch@infradead.org> · 2025-06-17
Re: [PATCH 06/10] fs/xfs: transition from deprecated .mmap hook to .mmap_prepare · Christian Brauner <brauner@kernel.org> · 2025-06-17
[PATCH 01/10] mm: rename call_mmap/mmap_prepare to vfs_mmap/mmap_prepare · Lorenzo Stoakes <hidden> · 2025-06-16
Re: [PATCH 01/10] mm: rename call_mmap/mmap_prepare to vfs_mmap/mmap_prepare · Christoph Hellwig <hch@infradead.org> · 2025-06-17
Re: [PATCH 01/10] mm: rename call_mmap/mmap_prepare to vfs_mmap/mmap_prepare · Lorenzo Stoakes <hidden> · 2025-06-17
Re: [PATCH 01/10] mm: rename call_mmap/mmap_prepare to vfs_mmap/mmap_prepare · Vlastimil Babka <hidden> · 2025-06-17
[PATCH 08/10] fs: convert simple use of generic_file_*_mmap() to .mmap_prepare() · Lorenzo Stoakes <hidden> · 2025-06-16
Re: [PATCH 08/10] fs: convert simple use of generic_file_*_mmap() to .mmap_prepare() · Viacheslav Dubeyko <hidden> · 2025-06-16
Re: [PATCH 08/10] fs: convert simple use of generic_file_*_mmap() to .mmap_prepare() · Jan Kara <jack@suse.cz> · 2025-06-17
Re: [PATCH 08/10] fs: convert simple use of generic_file_*_mmap() to .mmap_prepare() · Dave Kleikamp <hidden> · 2025-06-17
[PATCH 07/10] mm/filemap: introduce generic_file_*_mmap_prepare() helpers · Lorenzo Stoakes <hidden> · 2025-06-16
Re: [PATCH 07/10] mm/filemap: introduce generic_file_*_mmap_prepare() helpers · Jan Kara <jack@suse.cz> · 2025-06-17
Re: [PATCH 07/10] mm/filemap: introduce generic_file_*_mmap_prepare() helpers · Vlastimil Babka <hidden> · 2025-06-17
[PATCH 10/10] fs: replace mmap hook with .mmap_prepare for simple mappings · Lorenzo Stoakes <hidden> · 2025-06-16
Re: [PATCH 10/10] fs: replace mmap hook with .mmap_prepare for simple mappings · Damien Le Moal <dlemoal@kernel.org> · 2025-06-16
Re: [PATCH 10/10] fs: replace mmap hook with .mmap_prepare for simple mappings · Viacheslav Dubeyko <hidden> · 2025-06-16
Re: [PATCH 10/10] fs: replace mmap hook with .mmap_prepare for simple mappings · Jan Kara <jack@suse.cz> · 2025-06-17
Re: [PATCH 10/10] fs: replace mmap hook with .mmap_prepare for simple mappings · Christian Brauner <brauner@kernel.org> · 2025-06-17
Re: [PATCH 10/10] fs: replace mmap hook with .mmap_prepare for simple mappings · David Sterba <hidden> · 2025-06-18
Re: [PATCH 10/10] fs: replace mmap hook with .mmap_prepare for simple mappings · Ryusuke Konishi <konishi.ryusuke@gmail.com> · 2025-06-19
[PATCH 09/10] fs: convert most other generic_file_*mmap() users to .mmap_prepare() · Lorenzo Stoakes <hidden> · 2025-06-16
Re: [PATCH 09/10] fs: convert most other generic_file_*mmap() users to .mmap_prepare() · Jan Kara <jack@suse.cz> · 2025-06-17
Re: [PATCH 09/10] fs: convert most other generic_file_*mmap() users to .mmap_prepare() · Christian Brauner <brauner@kernel.org> · 2025-06-17
Re: [PATCH 00/10] convert the majority of file systems to mmap_prepare · Kent Overstreet <kent.overstreet@linux.dev> · 2025-06-16
Re: [PATCH 00/10] convert the majority of file systems to mmap_prepare · Al Viro <viro@zeniv.linux.org.uk> · 2025-06-16
Re: [PATCH 00/10] convert the majority of file systems to mmap_prepare · Jeff Layton <jlayton@kernel.org> · 2025-06-17
Re: [PATCH 00/10] convert the majority of file systems to mmap_prepare · Lorenzo Stoakes <hidden> · 2025-06-17
Re: [PATCH 00/10] convert the majority of file systems to mmap_prepare · Andrew Morton <akpm@linux-foundation.org> · 2025-06-16
Re: [PATCH 00/10] convert the majority of file systems to mmap_prepare · Christian Brauner <brauner@kernel.org> · 2025-06-17
Re: [PATCH 00/10] convert the majority of file systems to mmap_prepare · Christian Brauner <brauner@kernel.org> · 2025-06-17
Re: [PATCH 00/10] convert the majority of file systems to mmap_prepare · David Howells <dhowells@redhat.com> · 2025-06-17
Re: [PATCH 00/10] convert the majority of file systems to mmap_prepare · Lorenzo Stoakes <hidden> · 2025-06-17
Re: [PATCH 00/10] convert the majority of file systems to mmap_prepare · Jason Gunthorpe <jgg@nvidia.com> · 2025-08-01

From: Christoph Hellwig <hch@infradead.org>
Date: 2025-06-17 05:09:05
Also in: ceph-devel, intel-gfx, linux-bcachefs, linux-block, linux-btrfs, linux-cifs, linux-f2fs-devel, linux-fsdevel, linux-mm, linux-nfs, linux-um, linux-unionfs, linux-xfs, lkml, ntfs3, nvdimm, ocfs2-devel, v9fs

On Mon, Jun 16, 2025 at 08:33:25PM +0100, Lorenzo Stoakes wrote:

 STATIC int
-xfs_file_mmap(
-	struct file		*file,
-	struct vm_area_struct	*vma)
+xfs_file_mmap_prepare(
+	struct vm_area_desc *desc)

Please stick to the existing alignment for the declarations.

Otherwise this looks good.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help