Re: [PATCH 22/30] reiserfs: use bdev_nr_bytes instead of open coding it

don't use ->bd_inode to access the block device size v2 · Christoph Hellwig <hch@lst.de> · 2021-10-15
[PATCH 02/30] block: add a bdev_nr_bytes helper · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 02/30] block: add a bdev_nr_bytes helper · Matthew Wilcox <willy@infradead.org> · 2021-10-15
Re: [PATCH 02/30] block: add a bdev_nr_bytes helper · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 02/30] block: add a bdev_nr_bytes helper · Anton Altaparmakov <hidden> · 2021-10-15
Re: [PATCH 02/30] block: add a bdev_nr_bytes helper · Kees Cook <hidden> · 2021-10-15
[PATCH 01/30] block: move the SECTOR_SIZE related definitions to blk_types.h · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 01/30] block: move the SECTOR_SIZE related definitions to blk_types.h · Jan Kara <jack@suse.cz> · 2021-10-15
Re: [PATCH 01/30] block: move the SECTOR_SIZE related definitions to blk_types.h · Kees Cook <hidden> · 2021-10-15
Re: [PATCH 01/30] block: move the SECTOR_SIZE related definitions to blk_types.h · Chaitanya Kulkarni <hidden> · 2021-10-18
[PATCH 03/30] bcache: remove bdev_sectors · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 03/30] bcache: remove bdev_sectors · Chaitanya Kulkarni <hidden> · 2021-10-18
[PATCH 04/30] drbd: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 04/30] drbd: use bdev_nr_sectors instead of open coding it · Lee Duncan <lduncan@suse.com> · 2021-10-15
[PATCH 05/30] dm: use bdev_nr_sectors and bdev_nr_bytes instead of open coding them · Christoph Hellwig <hch@lst.de> · 2021-10-15
[PATCH 06/30] md: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-15
[PATCH 07/30] nvmet: use bdev_nr_bytes instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 07/30] nvmet: use bdev_nr_bytes instead of open coding it · Kees Cook <hidden> · 2021-10-15
[PATCH 09/30] fs: use bdev_nr_bytes instead of open coding it in blkdev_max_block · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 09/30] fs: use bdev_nr_bytes instead of open coding it in blkdev_max_block · Kees Cook <hidden> · 2021-10-15
[PATCH 08/30] target/iblock: use bdev_nr_bytes instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 08/30] target/iblock: use bdev_nr_bytes instead of open coding it · Kees Cook <hidden> · 2021-10-15
[PATCH 10/30] fs: simplify init_page_buffers · Christoph Hellwig <hch@lst.de> · 2021-10-15
[PATCH 12/30] btrfs: use bdev_nr_bytes instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 12/30] btrfs: use bdev_nr_bytes instead of open coding it · David Sterba <hidden> · 2021-10-15
Re: [PATCH 12/30] btrfs: use bdev_nr_bytes instead of open coding it · Kees Cook <hidden> · 2021-10-15
[PATCH 11/30] affs: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 11/30] affs: use bdev_nr_sectors instead of open coding it · Chaitanya Kulkarni <hidden> · 2021-10-18
[PATCH 13/30] cramfs: use bdev_nr_bytes instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 13/30] cramfs: use bdev_nr_bytes instead of open coding it · Kees Cook <hidden> · 2021-10-15
[PATCH 14/30] fat: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-15
[PATCH 15/30] hfs: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-15
[PATCH 16/30] hfsplus: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-15
[PATCH 17/30] jfs: use bdev_nr_bytes instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 17/30] jfs: use bdev_nr_bytes instead of open coding it · Kees Cook <hidden> · 2021-10-15
[PATCH 18/30] nfs/blocklayout: use bdev_nr_bytes instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 18/30] nfs/blocklayout: use bdev_nr_bytes instead of open coding it · Kees Cook <hidden> · 2021-10-15
[PATCH 20/30] ntfs3: use bdev_nr_bytes instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 20/30] ntfs3: use bdev_nr_bytes instead of open coding it · Kees Cook <hidden> · 2021-10-15
Re: [PATCH 20/30] ntfs3: use bdev_nr_bytes instead of open coding it · Kari Argillander <hidden> · 2021-10-16
[PATCH 19/30] nilfs2: use bdev_nr_bytes instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 19/30] nilfs2: use bdev_nr_bytes instead of open coding it · Ryusuke Konishi <konishi.ryusuke@gmail.com> · 2021-10-15
Re: [PATCH 19/30] nilfs2: use bdev_nr_bytes instead of open coding it · Kees Cook <hidden> · 2021-10-15
[PATCH 22/30] reiserfs: use bdev_nr_bytes instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 22/30] reiserfs: use bdev_nr_bytes instead of open coding it · Kees Cook <hidden> · 2021-10-15
Re: [PATCH 22/30] reiserfs: use bdev_nr_bytes instead of open coding it · Chaitanya Kulkarni <hidden> · 2021-10-18
[PATCH 21/30] pstore/blk: use bdev_nr_bytes instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 21/30] pstore/blk: use bdev_nr_bytes instead of open coding it · Kees Cook <hidden> · 2021-10-15
[PATCH 23/30] squashfs: use bdev_nr_bytes instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 23/30] squashfs: use bdev_nr_bytes instead of open coding it · Kees Cook <hidden> · 2021-10-15
[PATCH 24/30] block: use bdev_nr_bytes instead of open coding it in blkdev_fallocate · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 24/30] block: use bdev_nr_bytes instead of open coding it in blkdev_fallocate · Kees Cook <hidden> · 2021-10-15
[PATCH 25/30] block: add a sb_bdev_nr_blocks helper · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 25/30] block: add a sb_bdev_nr_blocks helper · Kees Cook <hidden> · 2021-10-15
Re: [PATCH 25/30] block: add a sb_bdev_nr_blocks helper · Chaitanya Kulkarni <hidden> · 2021-10-18
[PATCH 26/30] ext4: use sb_bdev_nr_blocks · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 26/30] ext4: use sb_bdev_nr_blocks · Chaitanya Kulkarni <hidden> · 2021-10-18
[PATCH 27/30] jfs: use sb_bdev_nr_blocks · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 27/30] jfs: use sb_bdev_nr_blocks · Dave Kleikamp <hidden> · 2021-10-15
[PATCH 28/30] ntfs: use sb_bdev_nr_blocks · Christoph Hellwig <hch@lst.de> · 2021-10-15
Re: [PATCH 28/30] ntfs: use sb_bdev_nr_blocks · Anton Altaparmakov <hidden> · 2021-10-15
[PATCH 29/30] reiserfs: use sb_bdev_nr_blocks · Christoph Hellwig <hch@lst.de> · 2021-10-15
[PATCH 30/30] udf: use sb_bdev_nr_blocks · Christoph Hellwig <hch@lst.de> · 2021-10-15

From: Kees Cook <hidden>
Date: 2021-10-15 16:56:53
Also in: dm-devel, linux-bcache, linux-block, linux-btrfs, linux-fsdevel, linux-nfs, linux-nvme, linux-raid, linux-scsi, ntfs3, target-devel

On Fri, Oct 15, 2021 at 03:26:35PM +0200, Christoph Hellwig wrote:

Use the proper helper to read the block device size and remove two
cargo culted checks that can't be false.

Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Kees Cook <redacted>

-- 
Kees Cook

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help