Thread (63 messages) 63 messages, 11 authors, 2021-10-18

Re: [PATCH 27/30] jfs: use sb_bdev_nr_blocks

From: Dave Kleikamp <hidden>
Date: 2021-10-15 14:18:36
Also in: dm-devel, linux-bcache, linux-block, linux-btrfs, linux-fsdevel, linux-nfs, linux-nvme, linux-raid, linux-scsi, ntfs3, target-devel

On 10/15/21 8:26AM, Christoph Hellwig wrote:
Use the sb_bdev_nr_blocks helper instead of open coding it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Kees Cook <redacted>
Acked-by: Dave Kleikamp <redacted>
quoted hunk ↗ jump to hunk
---
  fs/jfs/resize.c | 3 +--
  fs/jfs/super.c  | 3 +--
  2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/jfs/resize.c b/fs/jfs/resize.c
index a42dbb0d3d28a..8b9a72ae5efa7 100644
--- a/fs/jfs/resize.c
+++ b/fs/jfs/resize.c
@@ -86,8 +86,7 @@ int jfs_extendfs(struct super_block *sb, s64 newLVSize, int newLogSize)
  		goto out;
  	}
  
-	VolumeSize = i_size_read(sb->s_bdev->bd_inode) >> sb->s_blocksize_bits;
-
+	VolumeSize = sb_bdev_nr_blocks(sb);
  	if (VolumeSize) {
  		if (newLVSize > VolumeSize) {
  			printk(KERN_WARNING "jfs_extendfs: invalid size\n");
diff --git a/fs/jfs/super.c b/fs/jfs/super.c
index 9241caa161163..24cbc9946e01c 100644
--- a/fs/jfs/super.c
+++ b/fs/jfs/super.c
@@ -284,8 +284,7 @@ static int parse_options(char *options, struct super_block *sb, s64 *newLVSize,
  		}
  		case Opt_resize_nosize:
  		{
-			*newLVSize = i_size_read(sb->s_bdev->bd_inode) >>
-				sb->s_blocksize_bits;
+			*newLVSize = sb_bdev_nr_blocks(sb);
  			if (*newLVSize == 0)
  				pr_err("JFS: Cannot determine volume size\n");
  			break;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help