Re: [PATCH v1 2/2] ext4: Do not iput inode under running transaction in ext4_rename()
From: "Theodore Ts'o" <tytso@mit.edu>
Date: 2021-03-21 04:11:29
On Wed, Mar 03, 2021 at 09:17:03PM +0800, zhangyi (F) wrote:
In ext4_rename(), when RENAME_WHITEOUT failed to add new entry into
directory, it ends up dropping new created whiteout inode under the
running transaction. After commit <9b88f9fb0d2> ("ext4: Do not iput inode
under running transaction"), we follow the assumptions that evict() does
not get called from a transaction context but in ext4_rename() it breaks
this suggestion. Although it's not a real problem, better to obey it, so
this patch add inode to orphan list and stop transaction before final
iput().
Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>Thanks, applied. - Ted