Re: [PATCH v1 1/2] ext4: find old entry again if failed to rename whiteout
From: "Theodore Ts'o" <tytso@mit.edu>
Date: 2021-03-21 04:00:50
From: "Theodore Ts'o" <tytso@mit.edu>
Date: 2021-03-21 04:00:50
On Fri, Mar 12, 2021 at 10:01:50AM +0800, zhangyi (F) wrote:
In this error path of whiteout rename, we want to restore the old inode number and old name back to the old entry, it's just a rollback operation. The old entry will stay where it was in common cases, but it can be moved from the first block to the leaf block during make indexed dir for one special case, but it cannot be deleted in theory. So if we cannot find it again, there must some bad thing happen and the filesystem may probably inconsistency. So I calling ext4_std_error() here,or am I missing something?
After looking at this more closely, I agree, this should be OK. The directory is going to be locked, so it shouldn't be changing out from under us. Thanks, applied. - Ted