Thread (8 messages) 8 messages, 3 authors, 2018-01-31

Re: [PATCH v2] iversion: make inode_cmp_iversion{+raw} return bool instead of s64

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2018-01-31 16:46:42
Also in: linux-btrfs, linux-fsdevel, linux-integrity, linux-nfs, linux-xfs, lkml

On Wed, Jan 31, 2018 at 4:29 AM, Jeff Layton [off-list ref] wrote:
Do you mind just taking it directly? I don't have anything else queued
up for this cycle.
Done.

I wonder if "false for same, true for different" calling convention
makes much sense, but it matches the old "0 for same" so obviously
makes for a smaller diff.

If it ever ends up confusing people, maybe the sense of that function
should be reversed, and the name changed to something like
"same_inode_version()" or something.

But at least for now the situation seems ok to me,

            Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help