Re: [RFC -v2 5/8] ext4: Do not fail journal due to block allocator
From: Michal Hocko <mhocko@kernel.org>
Date: 2015-08-18 10:55:46
Also in:
linux-btrfs, linux-fsdevel, linux-mm, lkml
On Tue 18-08-15 12:39:03, Michal Hocko wrote: [...]
quoted hunk ↗ jump to hunk
@@ -992,9 +992,8 @@ static int ext4_mb_get_buddy_page_lock(struct super_block *sb, block = group * 2; pnum = block / blocks_per_page; poff = block % blocks_per_page; - page = find_or_create_page(inode->i_mapping, pnum, GFP_NOFS); - if (!page) - return -ENOMEM; + page = find_or_create_page(inode->i_mapping, pnum, + GFP_NOFS|__GFP_NOFAIL);
Scratch this one. find_or_create_page is allowed to return NULL. The patch is bogus. I was overly eager to turn all places to not check the return value. -- Michal Hocko SUSE Labs