Re: [RFC 8/8] btrfs: use __GFP_NOFAIL in alloc_btrfs_bio
From: David Sterba <dsterba@suse.com>
Date: 2015-08-05 16:32:12
Also in:
linux-btrfs, linux-fsdevel, linux-mm, lkml
From: David Sterba <dsterba@suse.com>
Date: 2015-08-05 16:32:12
Also in:
linux-btrfs, linux-fsdevel, linux-mm, lkml
On Wed, Aug 05, 2015 at 11:51:24AM +0200, mhocko@kernel.org wrote:
From: Michal Hocko <mhocko@suse.com> alloc_btrfs_bio is relying on GFP_NOFS to allocate a bio but since "mm: page_alloc: do not lock up GFP_NOFS allocations upon OOM" this is allowed to fail which can lead to [ 37.928625] kernel BUG at fs/btrfs/extent_io.c:4045 This is clearly undesirable and the nofail behavior should be explicit if the allocation failure cannot be tolerated. Signed-off-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>