Thread (88 messages) 88 messages, 2 authors, 2015-03-29

Re: [PATCH 12/54] e2fsck: clear i_block[] when there are too many bad mappings on a special inode

From: Theodore Ts'o <tytso@mit.edu>
Date: 2015-01-27 16:32:42

On Mon, Jan 26, 2015 at 11:36:50PM -0800, Darrick J. Wong wrote:
If we decide to clear a special inode because of bad mappings, we need
to zero the i_block array.  The clearing routine depends on setting
i_links_count to zero to keep us from re-checking the block maps,
but that field isn't checked for special inodes.  Therefore, if we
haven't erased the mappings, check_blocks will restart fsck and fsck
will try to check the blocks again, leading to an infinite loop.

(This seems easy to trigger if the bootloader inode extent map is
corrupted.)

Signed-off-by: Darrick J. Wong <redacted>
Applied, thanks.

						- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help