Thread (88 messages) 88 messages, 2 authors, 2015-03-29

Re: [PATCH 04/54] libext2fs: initialize i_extra_isize when writing EAs

From: Theodore Ts'o <tytso@mit.edu>
Date: 2015-01-27 16:02:13

On Mon, Jan 26, 2015 at 11:35:59PM -0800, Darrick J. Wong wrote:
If i_extra_isize is zero when we try to write extended attributes,
we'll end up writing the EA magic into the i_extra_isize field, which
causes a subsequent crash on big endian systems (when we try to write
0xEA02 bytes past the inode!).  Therefore when the field is zero, set
i_extra_isize to the desired extra_isize size, zero those bytes, and
write the EAs after the end of the extended inode.

v2: Don't bother if we have 128b inodes, and ensure that the value
is 32b-aligned so that the EA magic starts on a 32b boundary.

Signed-off-by: Darrick J. Wong <redacted>
Thanks, applied.

						- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help