Re: [PATCH 03/11] xfs: Remove some useless flags tests

[PATCH 0/11 RFC] quota: Unify VFS and XFS quota interfaces · Jan Kara <jack@suse.cz> · 2014-11-11
[PATCH 01/11] xfs: Remove useless test · Jan Kara <jack@suse.cz> · 2014-11-11
Re: [PATCH 01/11] xfs: Remove useless test · Dave Chinner <david@fromorbit.com> · 2014-11-11
[PATCH 02/11] xfs: Remove unused variable in xfs_qm_scall_quotaon() · Jan Kara <jack@suse.cz> · 2014-11-11
Re: [PATCH 02/11] xfs: Remove unused variable in xfs_qm_scall_quotaon() · Dave Chinner <david@fromorbit.com> · 2014-11-11
[PATCH 03/11] xfs: Remove some useless flags tests · Jan Kara <jack@suse.cz> · 2014-11-11
Re: [PATCH 03/11] xfs: Remove some useless flags tests · Dave Chinner <david@fromorbit.com> · 2014-11-11
[PATCH 04/11] quota: Split ->set_xstate callback into two · Jan Kara <jack@suse.cz> · 2014-11-11
Re: [PATCH 04/11] quota: Split ->set_xstate callback into two · Christoph Hellwig <hch@infradead.org> · 2014-11-13
Re: [PATCH 04/11] quota: Split ->set_xstate callback into two · Jan Kara <jack@suse.cz> · 2014-11-18
[PATCH 06/11] quota: Add ->sysquota_{on,off} callbacks for VFS quotas · Jan Kara <jack@suse.cz> · 2014-11-11
[PATCH 07/11] ext4: Use generic helpers for quotaon and quotaoff · Jan Kara <jack@suse.cz> · 2014-11-11
Re: [PATCH 07/11] ext4: Use generic helpers for quotaon and quotaoff · Christoph Hellwig <hch@infradead.org> · 2014-11-13
Re: [PATCH 07/11] ext4: Use generic helpers for quotaon and quotaoff · Jan Kara <jack@suse.cz> · 2014-11-18
[PATCH 08/11] ocfs2: Use generic helpers for quotaon and quotaoff · Jan Kara <jack@suse.cz> · 2014-11-11
[PATCH 09/11] quota: Remove quota_on_meta callback · Jan Kara <jack@suse.cz> · 2014-11-11
[PATCH 10/11] quota: Switch ->get_dqblk() and ->set_dqblk() to use bytes as space units · Jan Kara <jack@suse.cz> · 2014-11-11
Re: [PATCH 10/11] quota: Switch ->get_dqblk() and ->set_dqblk() to use bytes as space units · Dave Chinner <david@fromorbit.com> · 2014-11-18
Re: [PATCH 10/11] quota: Switch ->get_dqblk() and ->set_dqblk() to use bytes as space units · Jan Kara <jack@suse.cz> · 2014-12-12
Re: [PATCH 10/11] quota: Switch ->get_dqblk() and ->set_dqblk() to use bytes as space units · Jan Kara <jack@suse.cz> · 2014-12-12
[PATCH 05/11] quota: Wire up ->sysquota_{on,off} callbacks into Q_QUOTA{ON,OFF} · Jan Kara <jack@suse.cz> · 2014-11-11
[PATCH 11/11] quota: Store maximum space limit in bytes · Jan Kara <jack@suse.cz> · 2014-11-11

From: Dave Chinner <david@fromorbit.com>
Date: 2014-11-11 23:26:37
Also in: linux-fsdevel, linux-xfs

On Tue, Nov 11, 2014 at 10:04:17PM +0100, Jan Kara wrote:

'flags' have XFS_ALL_QUOTA_ACCT cleared immediately on function entry.
There's no point in checking these bits later in the function. Also
because we check something is going to change, we know some enforcement
bits are being added and thus there's no point in testing that later.

Signed-off-by: Jan Kara <jack@suse.cz>

Looks sane. I'll pick this up straight away.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help