Thread (5 messages) flat view 5 messages, 3 authors, 2012-02-27

Re: [PATCH 66/73] ext2: Split ext2_add_entry() from ext2_add_link() [ver #2]

From: Ted Ts'o <tytso@mit.edu>
Date: 2012-02-27 00:04:28
Also in: linux-fsdevel, lkml

On Tue, Feb 21, 2012 at 06:05:46PM +0000, David Howells wrote:
From: Valerie Aurora <redacted>

Allow future code to use the guts of ext2_add_link().

Original-author: Valerie Aurora [off-list ref]
Signed-off-by: David Howells <dhowells@redhat.com>
Cc: Jan Kara <jack@suse.cz>
Cc: linux-ext4@kernel.org
I'd suggest folding this in with the following patch (67/73).  It's
not clear from this patch why renaming ext2_add_link to
ext2_add_entry() makes sense and then adding a new ext2_add_link()
which calls ext_add_entry().   It doesn't seem to clarify much....

I won't insist on it, but this seems to be unnecessary complication.

      	    		       	  	       - Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help