Thread (12 messages) 12 messages, 4 authors, 2011-10-08

Re: [PATCH 2/2] ext4: MMP: fix error message rate-limiting logic in kmmpd

From: Ted Ts'o <tytso@mit.edu>
Date: 2011-10-08 21:25:22
Also in: lkml

On Fri, Sep 30, 2011 at 12:38:20AM +0100, Nikitas Angelinas wrote:
Current logic would print an error message only once, and then
'failed_writes' would stay at 1. Rework the loop to increment
'failed_writes' and print the error message every s_mmp_update_interval
* 60 seconds, as intended according to the comment.

Perhaps it would be better to reset 'failed_writes' to 0 on every
successful write, such that new errors are noticed sooner, but maybe in
the interest of efficiency it would be best not to add an operation on
every kmmpd thread run?

Signed-off-by: Nikitas Angelinas <redacted>
Signed-off-by: Andrew Perepechko <redacted>
Acked-by: Andreas Dilger <redacted>
Thanks, applied.

						- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help