Re: [PATCH 2/2] ext4: MMP: fix error message rate-limiting logic in kmmpd
From: Andreas Dilger <adilger.kernel@dilger.ca>
Date: 2011-09-23 18:51:58
Also in:
lkml
On 2011-09-22, at 6:23 PM, Nikitas Angelinas wrote:
Current logic would print an error message only once, and then 'failed_writes' would stay at 1. Rework the loop to increment 'failed_writes' and print the error message every s_mmp_update_interval * 60 seconds, as intended according to the comment. Perhaps it would be better to reset 'failed_writes' to 0 on every successful write, such that new errors are noticed sooner, but maybe in the interest of efficiency it would be best not to add an operation on every kmmpd thread run? Signed-off-by: Nikitas Angelinas <redacted> Signed-off-by: Andrew Perepechko <redacted>
Acked-by: Andreas Dilger <redacted> Thanks for the fix.
quoted hunk ↗ jump to hunk
--- fs/ext4/mmp.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c index 2fca64e..6b32742 100644 --- a/fs/ext4/mmp.c +++ b/fs/ext4/mmp.c@@ -125,8 +125,9 @@ static int kmmpd(void *data)* Don't spew too many error messages. Print one every * (s_mmp_update_interval * 60) seconds. */ - if (retval && (failed_writes % 60) == 0) { - ext4_error(sb, "Error writing to MMP block"); + if (retval) { + if ((failed_writes % 60) == 0) + ext4_error(sb, "Error writing to MMP block"); failed_writes++; } -- 1.7.4.4
Cheers, Andreas