Re: [PATCH] fix the outdated comment in ext2_nfs_get_inode()
From: Jan Kara <jack@suse.cz>
Date: 2011-08-30 10:35:48
Also in:
lkml
On Tue 30-08-11 17:53:58, Li Haifeng wrote:
quoted hunk ↗ jump to hunk
The function iget referred by the comment is replaced by ext2_iget . And the ext2_read_inode() is not exist, the ext2_iget is "neater". So the comment is fixed here. Signed-off-by: Li Haifeng <redacted> --- fs/ext2/super.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)diff --git a/fs/ext2/super.c b/fs/ext2/super.c index 1dd62ed..994ced3 100644 --- a/fs/ext2/super.c +++ b/fs/ext2/super.c@@ -327,10 +327,8 @@ static struct inode *ext2_nfs_get_inode(structsuper_block *sb, if (ino > le32_to_cpu(EXT2_SB(sb)->s_es->s_inodes_count)) return ERR_PTR(-ESTALE); - /* iget isn't really right if the inode is currently unallocated!! - * ext2_read_inode currently does appropriate checks, but - * it might be "neater" to call ext2_get_inode first and check - * if the inode is valid..... + /* + * ext2_iget isn't really right if the inode is currently unallocated!!
OK, but we should keep there a note that ext2_iget() does appropriate checks to handle stale inodes. Honza
*/
inode = ext2_iget(sb, ino);
if (IS_ERR(inode))
--
1.7.4.1-- Jan Kara [off-list ref] SUSE Labs, CR