Thread (3 messages) 3 messages, 2 authors, 2011-08-30
STALE5437d

[PATCH] fix the outdated comment in ext2_nfs_get_inode()

From: Li Haifeng <hidden>
Date: 2011-08-30 09:54:04
Also in: lkml
Subsystem: ext2 file system, filesystems (vfs and infrastructure), the rest · Maintainers: Jan Kara, Alexander Viro, Christian Brauner, Linus Torvalds

The function iget  referred by the comment is replaced by ext2_iget .
And the ext2_read_inode() is not exist, the ext2_iget is "neater". So
the comment is fixed here.

Signed-off-by: Li Haifeng <redacted>
---
 fs/ext2/super.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 1dd62ed..994ced3 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -327,10 +327,8 @@ static struct inode *ext2_nfs_get_inode(struct
super_block *sb,
    if (ino > le32_to_cpu(EXT2_SB(sb)->s_es->s_inodes_count))
        return ERR_PTR(-ESTALE);

-   /* iget isn't really right if the inode is currently unallocated!!
-    * ext2_read_inode currently does appropriate checks, but
-    * it might be "neater" to call ext2_get_inode first and check
-    * if the inode is valid.....
+   /*
+    * ext2_iget isn't really right if the inode is currently unallocated!!
     */
    inode = ext2_iget(sb, ino);
    if (IS_ERR(inode))
-- 
1.7.4.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help