Thread (24 messages) 24 messages, 6 authors, 2011-05-18

Re: [PATCHSET v3.1 0/7] data integrity: Stabilize pages during writeback for various fses

From: Chris Mason <hidden>
Date: 2011-05-10 16:24:50
Also in: linux-fsdevel, linux-mm, linux-scsi, lkml

Excerpts from Jan Kara's message of 2011-05-10 08:51:24 -0400:
On Mon 09-05-11 16:03:18, Darrick J. Wong wrote:
quoted
I am still chasing down what exactly is broken in ext3.  data=writeback mode
passes with no failures.  data=ordered, however, does not pass; my current
suspicion is that jbd is calling submit_bh on data buffers but doesn't call
page_mkclean to kick the userspace programs off the page before writing it.
  Yes, ext3 in data=ordered mode writes pages from
journal_commit_transaction() via submit_bh() without clearing page dirty
bits thus page_mkclean() is not called for these pages. Frankly, do you
really want to bother with adding support for ext2 and ext3? People can use
ext4 as a fs driver when they want to start using blk-integrity support.
Especially ext2 patch looks really painful and just from a quick look I can
see code e.g. in fs/ext2/namei.c which isn't handled by your patch yet.
I think ext23 are going to be pretty big changes, we're best off just
going with ext4.

-chris

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help