Re: [PATCH 2/7] fs: block_page_mkwrite should wait for writeback to finish
From: Jan Kara <jack@suse.cz>
Date: 2011-05-10 12:41:03
Also in:
linux-fsdevel, linux-mm, linux-scsi, lkml
On Mon 09-05-11 16:03:34, Darrick J. Wong wrote:
quoted hunk ↗ jump to hunk
For filesystems such as nilfs2 and xfs that use block_page_mkwrite, modify that function to wait for pending writeback before allowing the page to become writable. This is needed to stabilize pages during writeback for those two filesystems. Signed-off-by: Darrick J. Wong <redacted> --- fs/buffer.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)diff --git a/fs/buffer.c b/fs/buffer.c index a08bb8e..cf9a795 100644 --- a/fs/buffer.c +++ b/fs/buffer.c@@ -2361,6 +2361,7 @@ block_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf, if (!ret) ret = block_commit_write(page, 0, end); + wait_on_page_writeback(page);
Not that it matters much but it would seem more logical to me if we waited only in not-error case (i.e. after the error handling below). Honza
if (unlikely(ret)) {
unlock_page(page);
if (ret == -ENOMEM)-- Jan Kara [off-list ref] SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>