RE: [PATCH 14/14] x86/efi: Print size in binary units in efi_print_memmap
From: Elliott, Robert (Persistent Memory) <hidden>
Date: 2016-02-03 15:25:51
Also in:
lkml
-----Original Message----- From: Matt Fleming [mailto:matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org] Sent: Wednesday, February 3, 2016 5:28 AM To: Ingo Molnar <redacted> Cc: Laszlo Ersek <redacted>; H . Peter Anvin <redacted>; Thomas Gleixner [off-list ref]; linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux- kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Elliott, Robert (Persistent Memory) [off-list ref]; Andy Shevchenko [off-list ref]; Ard Biesheuvel [off-list ref]; Taku Izumi [off-list ref]; Linus Torvalds <torvalds@linux- foundation.org>; Andrew Morton [off-list ref] Subject: Re: [PATCH 14/14] x86/efi: Print size in binary units in efi_print_memmap
...
OK, this patch has caused enough headaches. Let's drop it from this series. Robert, Andy, feel free to resubmit it after you've addressed everyone's concerns and we can discuss it in isolation.
We could just delete the size print altogether - better to print nothing than a silently rounded number. The end address already communicates the size - it's just not as readable. The e820 table prints don't bother with a size print. That would also shorten these extremely wide prints to 116 characters (131 if printk time is enabled). [ 0.000000] BIOS-e820: [mem 0x0000001880000000-0x000000207fffffff] reserved vs. [ 0.000000] efi: mem62: [Reserved | | |NV| | | | | |WB|WT|WC|UC] range=[0x0000001880000000-0x000000207fffffff] (32 GiB) --- Robert Elliott, HPE Persistent Memory