Thread (45 messages) 45 messages, 3 authors, 2026-05-27

Re: [PATCH v5 04/28] mtd: spi-nor: swp: Improve locking user experience

From: Pratyush Yadav <pratyush@kernel.org>
Date: 2026-05-26 15:20:10
Also in: lkml

On Tue, May 26 2026, Miquel Raynal wrote:
Hi Pratyush,
quoted
And here's what I am thinking: the first 9 patches are reviewed and good
to go. I want to land them in this merge window so we cut down your
patchset and land stuff sooner.

Unfortunately I just can't seem to find time to review this series so I
hope this helps some at least.
I know what the maintainer load can be, sometimes it does not play well
with the rest of the your personal and professional duties. But the
series has already been on the list for about 8 months, it's been looked
at by other people, the ones who had enough time to dedicate to it. From
my perspective, asking such contributions to wait indefinitely and then
suggesting partial application without a technical reason is not a
sustainable way to handle contributions. This series has not moved much,
it could have been applied *much* earlier. I've now addressed most of
the comments from Sashiko, v6 is coming, further improving the quality
for sure, as there were bugs - there are always. I am of course happy to
address further technical concerns, if there are any, but I would
strongly prefer merging the series as the coherent set it was intended
to be, rather than only taking the preparatory parts.
Unfortunately I am only a patch monkey for SPI NOR these days and do not
have any time to do reviews, especially for big series. I mainly check
for reviewed patches and try to apply them. Even that is becoming harder
these days since I am more busy at new $DAYJOB.

I understand your frustration, and do take the blame for this, but
unfortunately can't promise anything better in the future. We pretty
much don't have any active reviewers in SPI NOR. Michael and Tudor are
also short on time these days. If your employer cares about SPI NOR,
perhaps you can encourage them to support developers in helping out with
reviews and maintenance.

Applying the reviewed patches reduces the total patchset size and does
make things easier to review and land. So I don't get why you are so
opposed to the idea.

But anyway, I'll bite the bullet here and apply the series. You
generally have high quality patches so I am not super worried about this
to begin with. We can deal with the bugs or shortcomings later I
suppose...
On top of that, as mentioned previously, I now have additional spi-nor
improvements and cleanups waiting behind this series. Keeping such a
large stack of out of tree patches for months is becoming painful to
maintain.

Thanks,
Miquèl
-- 
Regards,
Pratyush Yadav
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help