[AMD Official Use Only - General]

Hi Fenghua,

-----Original Message-----
From: Yu, Fenghua <redacted>
Sent: Wednesday, November 23, 2022 12:26 PM
To: Moger, Babu <Babu.Moger@amd.com>; corbet@lwn.net; Chatre, Reinette
[off-list ref]; tglx@linutronix.de; mingo@redhat.com;
bp@alien8.de
Cc: dave.hansen@linux.intel.com; x86@kernel.org; hpa@zytor.com;
paulmck@kernel.org; akpm@linux-foundation.org; quic_neeraju@quicinc.com;
rdunlap@infradead.org; damien.lemoal@opensource.wdc.com;
songmuchun@bytedance.com; peterz@infradead.org; jpoimboe@kernel.org;
pbonzini@redhat.com; Bae, Chang Seok [off-list ref];
pawan.kumar.gupta@linux.intel.com; jmattson@google.com;
daniel.sneddon@linux.intel.com; Das1, Sandipan [off-list ref];
Luck, Tony [off-list ref]; james.morse@arm.com; linux-
doc@vger.kernel.org; linux-kernel@vger.kernel.org; bagasdotme@gmail.com;
Eranian, Stephane [off-list ref]
Subject: RE: [PATCH v8 04/13] x86/resctrl: Include new features in command
line options

Hi, Babu,

quoted

Add the command line options to disable the new features.

s/disable/disable or enable/

Sure.
Thanks
Babu

quoted

smba : Slow Memory Bandwidth Allocation bmec : Bandwidth Monitor Event
Configuration.

Signed-off-by: Babu Moger <babu.moger@amd.com>
---
 Documentation/admin-guide/kernel-parameters.txt |    2 +-
 arch/x86/kernel/cpu/resctrl/core.c              |    4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/admin-guide/kernel-parameters.txt

b/Documentation/admin-guide/kernel-parameters.txt
index a465d5242774..f3f0870144fb 100644

--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt

@@ -5190,7 +5190,7 @@
 	rdt=		[HW,X86,RDT]
 			Turn on/off individual RDT features. List is:
 			cmt, mbmtotal, mbmlocal, l3cat, l3cdp, l2cat, l2cdp,
-			mba.
+			mba, smba, bmec.
 			E.g. to turn on cmt and turn off mba use:
 				rdt=cmt,!mba

diff --git a/arch/x86/kernel/cpu/resctrl/core.c

b/arch/x86/kernel/cpu/resctrl/core.c
index 4b970e7192e8..e31c98e2fafc 100644

--- a/arch/x86/kernel/cpu/resctrl/core.c
+++ b/arch/x86/kernel/cpu/resctrl/core.c

@@ -659,6 +659,8 @@ enum {
 	RDT_FLAG_L2_CAT,
 	RDT_FLAG_L2_CDP,
 	RDT_FLAG_MBA,
+	RDT_FLAG_SMBA,
+	RDT_FLAG_BMEC,
 };

 #define RDT_OPT(idx, n, f)	\

@@ -682,6 +684,8 @@ static struct rdt_options rdt_options[]  __initdata = {
 	RDT_OPT(RDT_FLAG_L2_CAT,    "l2cat",	X86_FEATURE_CAT_L2),
 	RDT_OPT(RDT_FLAG_L2_CDP,    "l2cdp",

	X86_FEATURE_CDP_L2),

quoted

 	RDT_OPT(RDT_FLAG_MBA,	    "mba",	X86_FEATURE_MBA),
+	RDT_OPT(RDT_FLAG_SMBA,	    "smba",	X86_FEATURE_SMBA),
+	RDT_OPT(RDT_FLAG_BMEC,	    "bmec",	X86_FEATURE_BMEC),
 };
 #define NUM_RDT_OPTIONS ARRAY_SIZE(rdt_options)

Thanks.

-Fenghua