[AMD Official Use Only - General]

Hi Reinette,

-----Original Message-----
From: Reinette Chatre <reinette.chatre@intel.com>
Sent: Tuesday, November 22, 2022 6:26 PM
To: Moger, Babu <Babu.Moger@amd.com>; corbet@lwn.net;
tglx@linutronix.de; mingo@redhat.com; bp@alien8.de
Cc: fenghua.yu@intel.com; dave.hansen@linux.intel.com; x86@kernel.org;
hpa@zytor.com; paulmck@kernel.org; akpm@linux-foundation.org;
quic_neeraju@quicinc.com; rdunlap@infradead.org;
damien.lemoal@opensource.wdc.com; songmuchun@bytedance.com;
peterz@infradead.org; jpoimboe@kernel.org; pbonzini@redhat.com;
chang.seok.bae@intel.com; pawan.kumar.gupta@linux.intel.com;
jmattson@google.com; daniel.sneddon@linux.intel.com; Das1, Sandipan
[off-list ref]; tony.luck@intel.com; james.morse@arm.com;
linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org;
bagasdotme@gmail.com; eranian@google.com
Subject: Re: [PATCH v8 13/13] Documentation/x86: Update resctrl.rst for new
features

Hi Babu,

On 11/4/2022 1:01 PM, Babu Moger wrote:
...

quoted

@@ -464,6 +539,26 @@ Memory bandwidth domain is L3 cache.

 	MB:<cache_id0>=bw_MBps0;<cache_id1>=bw_MBps1;...

+Slow Memory Bandwidth Allocation (SMBA)
+---------------------------------------
+AMD hardware support Slow Memory Bandwidth Allocation (SMBA) feature.

How about
AMD hardware supports the Slow Memory Bandwidth Allocation (SMBA)
feature.
or
AMD hardware supports Slow Memory Bandwidth Allocation (SMBA).

Sure.

quoted

+Currently, CXL.memory is the only supported "slow" memory device.

What does "Currently" mean here? If there is a plan for changes, could that be
shared? Otherwise maybe just remove it: "CXL.memory is the only supported
"slow" memory device."

There is no change of plan. I will remove "Currently"

quoted

+With the support of SMBA, the hardware enables bandwidth allocation
+on the slow memory devices. If there are multiple such devices in the
+system, the throttling logic groups all the slow sources together and
+applies the limit on them as a whole.
+
+The presence of SMBA (with CXL.memory) is independent of slow memory
+devices presence. If there is no such devices on the system, then

Maybe "is no such device" or "are no such devices"?

It should be "If there are no such devices".   Will correct it.

quoted

+setting the configuring SMBA will have no impact on the performance

"setting the configuring SMBA" is hard to parse. How about just "configuring
SMBA"?

Sure.
Thanks
Babu