Re: [PATCH v2 3/5] tracing: Fix operator precedence for hist triggers expression

On Wed, Oct 20, 2021 at 7:28 AM Steven Rostedt [off-list ref] wrote:

On Tue, 19 Oct 2021 18:31:40 -0700
Kalesh Singh [off-list ref] wrote:

quoted

+     minus_op = strrchr(str, '-');
+     if (minus_op) {
+             /* Unfortunately, the modifier ".sym-offset" can confuse things. */
+             if (minus_op - str >= 4 && !strncmp(minus_op - 4, ".sym-offset", 11))
+                     goto out;

I was thinking about this, and perhaps we can add this later, but we could
just replace all ".sym-offset" with ".symXoffset" after receiving it from
the user. Then it won't be an issue during prasing.

That's a good idea. It would clean things up a bit and avoid bailing
out if the user has a sym-offest in an expression string. I can send a
separate patch for this.

-- Steve