Thread (30 messages) 30 messages, 12 authors, 2022-07-27

Re: [PATCH] Introduce the pkill_on_warn boot parameter

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2021-10-02 18:31:42
Also in: linux-hardening, lkml

On Sat, 2 Oct 2021 18:04:10 +0000
Al Viro [off-list ref] wrote:
quoted
@@ -610,6 +611,9 @@ void __warn(const char *file, int line, void *caller, unsigned taint,
 
 	print_oops_end_marker();
 
+	if (pkill_on_warn && system_state >= SYSTEM_RUNNING)
+		do_group_exit(SIGKILL);
+  
Wait a sec...  do_group_exit() is very much not locking-neutral.
Aren't you introducing a bunch of potential deadlocks by adding
that?
Perhaps add an irq_work() here to trigger the do_group_exit() from a
"safe" interrupt context?

-- Steve
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help