Thread (30 messages) 30 messages, 12 authors, 2022-07-27

Re: [PATCH] Introduce the pkill_on_warn boot parameter

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2021-10-02 16:59:27
Also in: linux-hardening, lkml

On Sat, Oct 2, 2021 at 4:41 AM Alexander Popov [off-list ref] wrote:
And what do you think about the proposed pkill_on_warn?
Honestly, I don't see the point.

If you can reliably trigger the WARN_ON some way, you can probably
cause more problems by fooling some other process to trigger it.

And if it's unintentional, then what does the signal help?

So rather than a "rationale" that makes little sense, I'd like to hear
of an actual _use_ case. That's different. That's somebody actually
_using_ that pkill to good effect for some particular load.

That said, I don't much care in the end. But it sounds like a
pointless option to just introduce yet another behavior to something
that should never happen anyway, and where the actual
honest-to-goodness reason for WARN_ON() existing is already being
fulfilled (ie syzbot has been very effective at flushing things like
that out).

                   Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help