Thread (45 messages) 45 messages, 4 authors, 2021-09-20

Re: [PATCH 01/15] dmr: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

From: Fernando Ramos <hidden>
Date: 2021-09-17 22:07:15
Also in: amd-gfx, dri-devel, intel-gfx, linux-arm-msm, linux-renesas-soc, linux-tegra, lkml, nouveau

Could you please fix the subject, changing dmr to drm?
Ups! Sure, I'll fix that. Thanks for noticing.

I think you can just reuse 'ret' instead of creating a new variable. That
ensures if the lock fails we return the error from the macros.
I didn't reuse "ret" because otherwise I would have had to change the prototype
of the function (which currently returns a "bool" instead of an "int").

However I could, for example, check for any error and convert that into "false".
Would that be ok?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help