Re: [PATCH v1] driver: base: Add driver filter support

From
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date
2021-08-05 17:51:31
Also in
lkml
Reply to
Andi Kleen, 2021-08-05
On Thu, Aug 05, 2021 at 06:52:25AM -0700, Andi Kleen wrote:
quoted
Both thunderbolt and USB have the idea of "authorized" devices, that is
the logic that should be made generic and available for all busses to
use, by moving it to the driver core, just like the "removable" logic
got moved to the driver core recently (see 70f400d4d957 ("driver core:
Move the "removable" attribute from USB to core")
This looks like it's controlled by udev?  Have a default per bus, and let
user space override it before setting up the device.
It's controlled by whatever you want to use in userspace.  usbguard has
been handling this logic in userspace for over a decade now just fine.
This doesn't help us handle builtin drivers that initialize before user
space is up.
Then have the default setting for your bus be "unauthorized" like we
allow for some busses today.
We need something that works for all drivers. Also cannot just use a default
at bootup because some drivers (like virtio or rtc) need to be initialized
in early boot to make the system functional at all. So you need a way to
distinguish these two cases in the pre user space boot.

That's basically what this patch implements the infrastructure for.
It also ignores the existing implementation we already have for this for
some busses, please do not do that.
quoted
Please use that type of interface, as we already have userspace tools
using it, and expand it for all busses in the system to use if they
want.  Otherwise with this proposal you will end up with multiple ways
to control the same bus type with different types of "filtering",
ensuring a mess.
How would such a proposal work for a platform driver that doesn't have a
bus?
There is a platform bus, it's just a fake one.  The platform bus code
does the binding just like any other bus does, why is platform somehow
"special"?  Except for how it is abused...

thanks,

greg k-h
Thread (44 messages) 44 messages, 6 authors, last reply 2021-08-06
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help