Thread (43 messages) flat view 43 messages, 4 authors, 2021-07-23

Re: [PATCH v2 13/14] vfio/gvt: Fix open/close when multiple device FDs are open

From: Christoph Hellwig <hch@lst.de>
Date: 2021-07-23 08:14:23
Also in: intel-gfx, kvm, linux-s390

On Tue, Jul 20, 2021 at 02:42:59PM -0300, Jason Gunthorpe wrote:
The user can open multiple device FDs if it likes, however the open
function calls vfio_register_notifier() on device global state. Calling
vfio_register_notifier() twice will trigger a WARN_ON from
notifier_chain_register() and the first close will wrongly delete the
notifier and more.

Since these really want the new open/close_device() semantics just change
the function over.

Reviewed-by: Zhenyu Wang <redacted>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help