[PATCH v2 00/14] Provide core infrastructure for managing open/release · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-20
[PATCH v2 01/14] vfio/samples: Remove module get/put · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-20
Re: [PATCH v2 01/14] vfio/samples: Remove module get/put · Christoph Hellwig <hch@lst.de> · 2021-07-23
[PATCH v2 02/14] vfio/mbochs: Fix missing error unwind in mbochs_probe() · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-20
Re: [PATCH v2 02/14] vfio/mbochs: Fix missing error unwind in mbochs_probe() · Alex Williamson <hidden> · 2021-07-20
Re: [PATCH v2 02/14] vfio/mbochs: Fix missing error unwind in mbochs_probe() · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-20
Re: [PATCH v2 02/14] vfio/mbochs: Fix missing error unwind in mbochs_probe() · Alex Williamson <hidden> · 2021-07-20
Re: [PATCH v2 02/14] vfio/mbochs: Fix missing error unwind in mbochs_probe() · Cornelia Huck <cohuck@redhat.com> · 2021-07-21
Re: [PATCH v2 02/14] vfio/mbochs: Fix missing error unwind in mbochs_probe() · Cornelia Huck <cohuck@redhat.com> · 2021-07-21
[PATCH v2 10/14] vfio/pci: Reorganize VFIO_DEVICE_PCI_HOT_RESET to use the device set · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-20
Re: [PATCH v2 10/14] vfio/pci: Reorganize VFIO_DEVICE_PCI_HOT_RESET to use the device set · Christoph Hellwig <hch@lst.de> · 2021-07-23
Re: [PATCH v2 10/14] vfio/pci: Reorganize VFIO_DEVICE_PCI_HOT_RESET to use the device set · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-23
[PATCH v2 04/14] vfio: Provide better generic support for open/release vfio_device_ops · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-20
Re: [PATCH v2 04/14] vfio: Provide better generic support for open/release vfio_device_ops · Cornelia Huck <cohuck@redhat.com> · 2021-07-22
Re: [PATCH v2 04/14] vfio: Provide better generic support for open/release vfio_device_ops · Christoph Hellwig <hch@lst.de> · 2021-07-23
Re: [PATCH v2 04/14] vfio: Provide better generic support for open/release vfio_device_ops · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-23
[PATCH v2 14/14] vfio: Remove struct vfio_device_ops open/release · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-20
Re: [PATCH v2 14/14] vfio: Remove struct vfio_device_ops open/release · Christoph Hellwig <hch@lst.de> · 2021-07-23
[PATCH v2 03/14] vfio: Introduce a vfio_uninit_group_dev() API call · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-20
Re: [PATCH v2 03/14] vfio: Introduce a vfio_uninit_group_dev() API call · Cornelia Huck <cohuck@redhat.com> · 2021-07-21
Re: [PATCH v2 03/14] vfio: Introduce a vfio_uninit_group_dev() API call · Christoph Hellwig <hch@lst.de> · 2021-07-23
[PATCH v2 06/14] vfio/fsl: Move to the device set infrastructure · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-20
Re: [PATCH v2 06/14] vfio/fsl: Move to the device set infrastructure · Christoph Hellwig <hch@lst.de> · 2021-07-23
Re: [PATCH v2 06/14] vfio/fsl: Move to the device set infrastructure · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-23
Re: [PATCH v2 06/14] vfio/fsl: Move to the device set infrastructure · Christoph Hellwig <hch@lst.de> · 2021-07-23
Re: [PATCH v2 06/14] vfio/fsl: Move to the device set infrastructure · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-23
[PATCH v2 12/14] vfio/ap,ccw: Fix open/close when multiple device FDs are open · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-20
[PATCH v2 09/14] vfio/pci: Change vfio_pci_try_bus_reset() to use the dev_set · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-20
Re: [PATCH v2 09/14] vfio/pci: Change vfio_pci_try_bus_reset() to use the dev_set · Christoph Hellwig <hch@lst.de> · 2021-07-23
Re: [PATCH v2 09/14] vfio/pci: Change vfio_pci_try_bus_reset() to use the dev_set · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-23
[PATCH v2 11/14] vfio/mbochs: Fix close when multiple device FDs are open · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-20
Re: [PATCH v2 11/14] vfio/mbochs: Fix close when multiple device FDs are open · Christoph Hellwig <hch@lst.de> · 2021-07-23
[PATCH v2 07/14] vfio/platform: Use open_device() instead of open coding a refcnt scheme · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-20
Re: [PATCH v2 07/14] vfio/platform: Use open_device() instead of open coding a refcnt scheme · Cornelia Huck <cohuck@redhat.com> · 2021-07-22
Re: [PATCH v2 07/14] vfio/platform: Use open_device() instead of open coding a refcnt scheme · Christoph Hellwig <hch@lst.de> · 2021-07-23
Re: [PATCH v2 07/14] vfio/platform: Use open_device() instead of open coding a refcnt scheme · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-23
[PATCH v2 08/14] vfio/pci: Move to the device set infrastructure · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-20
Re: [PATCH v2 08/14] vfio/pci: Move to the device set infrastructure · Christoph Hellwig <hch@lst.de> · 2021-07-23
Re: [PATCH v2 08/14] vfio/pci: Move to the device set infrastructure · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-23
[PATCH v2 13/14] vfio/gvt: Fix open/close when multiple device FDs are open · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-20
Re: [PATCH v2 13/14] vfio/gvt: Fix open/close when multiple device FDs are open · Christoph Hellwig <hch@lst.de> · 2021-07-23
[PATCH v2 05/14] vfio/samples: Delete useless open/close · Jason Gunthorpe <jgg@nvidia.com> · 2021-07-20
Re: [PATCH v2 05/14] vfio/samples: Delete useless open/close · Christoph Hellwig <hch@lst.de> · 2021-07-23

Re: [PATCH v2 11/14] vfio/mbochs: Fix close when multiple device FDs are open

From: Christoph Hellwig <hch@lst.de>
Date: 2021-07-23 08:13:41
Also in: intel-gfx, kvm, linux-s390

On Tue, Jul 20, 2021 at 02:42:57PM -0300, Jason Gunthorpe wrote:

mbochs_close() iterates over global device state and frees it. Currently
this is done every time a device FD is closed, but if multiple device FDs
are open this could corrupt other still active FDs.

Change this to use close_device() so it only runs on the last close.

Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help